redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: ks7010: refactor ks_wlan_set_phy_type function

Browse source 
Handle invalid values first and assign good ones at the
end if it is the case. This makes code simplier.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sergio Paracuellos 2018-05-04 06:16:42 +02:00 committed by Greg Kroah-Hartman
parent 7f3c8bb5bc
commit 81255d867c
1 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
drivers/staging/ks7010/ks_wlan_net.c
View file

@ -1960,17 +1960,14 @@ static int ks_wlan_set_phy_type(struct net_device *dev,
if (priv->sleep_mode == SLP_SLEEP)
return -EPERM;
/* for SLEEP MODE */
if (*uwrq == D_11B_ONLY_MODE) { /* 0 */
priv->reg.phy_type = D_11B_ONLY_MODE;
} else if (*uwrq == D_11G_ONLY_MODE) { /* 1 */
priv->reg.phy_type = D_11G_ONLY_MODE;
} else if (*uwrq == D_11BG_COMPATIBLE_MODE) { /* 2 */
priv->reg.phy_type = D_11BG_COMPATIBLE_MODE;
} else {
return -EINVAL;
}
if (*uwrq != D_11B_ONLY_MODE &&
*uwrq != D_11G_ONLY_MODE &&
*uwrq != D_11BG_COMPATIBLE_MODE)
return -EINVAL;
/* for SLEEP MODE */
priv->reg.phy_type = *uwrq;
priv->need_commit |= SME_MODE_SET;
return -EINPROGRESS; /* Call commit handler */
}