redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

lseek(fd, n, SEEK_END) does *not* go to eof - n 

When you copy some code, you are supposed to read it.  If nothing else,
there's a chance to spot and fix an obvious bug instead of sharing it...

X-Song: "I Got It From Agnes", by Tom Lehrer
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
[ Tom Lehrer? You're dating yourself, Al ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
hifive-unleashed-5.1
Al Viro 2013-06-16 18:06:06 +01:00 committed by Linus Torvalds
parent 7d13205581
commit 8177a9d79c
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/brocade/bna/bnad_debugfs.c
View File

@ -244,7 +244,7 @@ bnad_debugfs_lseek(struct file *file, loff_t offset, int orig)
file->f_pos += offset;
break;
case 2:
file->f_pos = debug->buffer_len - offset;
file->f_pos = debug->buffer_len + offset;
break;
default:
return -EINVAL;

2
drivers/scsi/bfa/bfad_debugfs.c
View File

@ -186,7 +186,7 @@ bfad_debugfs_lseek(struct file *file, loff_t offset, int orig)
file->f_pos += offset;
break;
case 2:
file->f_pos = debug->buffer_len - offset;
file->f_pos = debug->buffer_len + offset;
break;
default:
return -EINVAL;

2
drivers/scsi/fnic/fnic_debugfs.c
View File

@ -174,7 +174,7 @@ static loff_t fnic_trace_debugfs_lseek(struct file *file,
pos = file->f_pos + offset;
break;
case 2:
pos = fnic_dbg_prt->buffer_len - offset;
pos = fnic_dbg_prt->buffer_len + offset;
}
return (pos < 0 || pos > fnic_dbg_prt->buffer_len) ?
-EINVAL : (file->f_pos = pos);

2
drivers/scsi/lpfc/lpfc_debugfs.c
View File

@ -1178,7 +1178,7 @@ lpfc_debugfs_lseek(struct file *file, loff_t off, int whence)
pos = file->f_pos + off;
break;
case 2:
pos = debug->len - off;
pos = debug->len + off;
}
return (pos < 0 || pos > debug->len) ? -EINVAL : (file->f_pos = pos);
}