redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

of: unittest: fix an error code in of_unittest_apply_overlay() 

We accidentally return zero on failure instead of a negative error code.

Fixes: 39a751a4cb ("of: change overlay apply input data from unflattened to FDT")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rob Herring <robh@kernel.org>
hifive-unleashed-5.1
Dan Carpenter 2018-03-14 23:08:28 +03:00 committed by Rob Herring
parent 202fbf4865
commit 827473268e
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/of/unittest.c
View File

@ -1423,15 +1423,13 @@ static int __init of_unittest_apply_overlay(int overlay_nr, int unittest_nr,
int *overlay_id)
{
const char *overlay_name;
int ret;
overlay_name = overlay_name_from_nr(overlay_nr);
ret = overlay_data_apply(overlay_name, overlay_id);
if (!ret) {
if (!overlay_data_apply(overlay_name, overlay_id)) {
unittest(0, "could not apply overlay \"%s\"\n",
overlay_name);
return ret;
return -EFAULT;
}
of_unittest_track_overlay(*overlay_id);