redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

Staging: silicom: use kstrtoint_from_user()

Browse source 
The main problem with the hand rolled code was that there weren't any
range checks so you could corrupt memory by writing too much data to
the proc file.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Cotey <puff65537@bansheeslibrary.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2012-09-14 11:11:35 +03:00 committed by Greg Kroah-Hartman
parent e4c536b72f
commit 82e6bb0398
1 changed files with 10 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
drivers/staging/silicom/bp_mod.c
View file

@ -8071,20 +8071,13 @@ int
set_bypass_wd_pfs(struct file *file, const char *buffer,
unsigned long count, void *data)
{
char kbuf[256];
bpctl_dev_t *pbp_device_block = (bpctl_dev_t *) data;
int timeout;
int ret;
unsigned int timeout = 0;
char *timeout_ptr = kbuf;
if (copy_from_user(&kbuf, buffer, count)) {
return -1;
}
timeout_ptr = kbuf;
timeout = atoi(&timeout_ptr);
ret = kstrtoint_from_user(buffer, count, 10, &timeout);
if (ret)
return ret;
set_bypass_wd_fn(pbp_device_block, timeout);
return count;
@ -8712,18 +8705,13 @@ int
set_wd_autoreset_pfs(struct file *file, const char *buffer,
unsigned long count, void *data)
{
char kbuf[256];
bpctl_dev_t *pbp_device_block = (bpctl_dev_t *) data;
u32 timeout = 0;
char *timeout_ptr = kbuf;
if (copy_from_user(&kbuf, buffer, count)) {
return -1;
}
timeout_ptr = kbuf;
timeout = atoi(&timeout_ptr);
int timeout;
int ret;
ret = kstrtoint_from_user(buffer, count, 10, &timeout);
if (ret)
return ret;
set_wd_autoreset_fn(pbp_device_block, timeout);
return count;