redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

Bluetooth: Don't increment twice in eir_has_data_type()

Browse source 
The parsed variable is already incremented inside the for-loop so there
no need to increment it again (not to mention that the code was
incrementing it the wrong amount).

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo Padovan <gustavo@padovan.org>
This commit is contained in:
Johan Hedberg 2012-03-26 14:21:41 +03:00 committed by Gustavo Padovan
parent 8d7e1c7f7e
commit 84d9d0716b
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
include/net/bluetooth/hci_core.h
View file

@ -907,11 +907,10 @@ static inline void hci_role_switch_cfm(struct hci_conn *conn, __u8 status,
static inline bool eir_has_data_type(u8 *data, size_t data_len, u8 type)
{
u8 field_len;
size_t parsed;
size_t parsed = 0;
for (parsed = 0; parsed < data_len - 1; parsed += field_len) {
field_len = data[0];
while (parsed < data_len - 1) {
u8 field_len = data[0];
if (field_len == 0)
break;