redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

vfs: dedupe should return EPERM if permission is not granted 

Right now we return EINVAL if a process does not have permission to dedupe a
file. This was an oversight on my part. EPERM gives a true description of
the nature of our error, and EINVAL is already used for the case that the
filesystem does not support dedupe.

Signed-off-by: Mark Fasheh <mfasheh@suse.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Acked-by: David Sterba <dsterba@suse.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
hifive-unleashed-5.1
Mark Fasheh 2018-09-10 16:21:18 -07:00 committed by Al Viro
parent 5de4480ae7
commit 85c95f208f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/read_write.c
View File

@ -1991,7 +1991,7 @@ int vfs_dedupe_file_range_one(struct file *src_file, loff_t src_pos,
if (ret < 0)
goto out_drop_write;
ret = -EINVAL;
ret = -EPERM;
if (!allow_file_dedupe(dst_file))
goto out_drop_write;