redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

raid5-cache: check stripe finish out of order 

stripes could finish out of order. Hence r5l_move_io_unit_list() of
__r5l_stripe_write_finished might not move any entry and leave
stripe_end_ios list empty.

This applies on top of http://marc.info/?l=linux-raid&m=144122700510667

Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: NeilBrown <neilb@suse.com>
hifive-unleashed-5.1
Shaohua Li 2015-09-04 14:14:05 -07:00 committed by NeilBrown
parent bd18f6462f
commit 85f2f9a4f4
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/md/raid5-cache.c
View File

@ -550,8 +550,13 @@ static void __r5l_stripe_write_finished(struct r5l_io_unit *io)
spin_lock_irqsave(&log->io_list_lock, flags);
__r5l_set_io_unit_state(io, IO_UNIT_STRIPE_END);
/* might move 0 entry */
r5l_move_io_unit_list(&log->flushed_ios, &log->stripe_end_ios,
IO_UNIT_STRIPE_END);
if (list_empty(&log->stripe_end_ios)) {
spin_unlock_irqrestore(&log->io_list_lock, flags);
return;
}
last = list_last_entry(&log->stripe_end_ios,
struct r5l_io_unit, log_sibling);