nbd: make the config put is called before the notifying the waiter
There has one race case for ceph's rbd-nbd tool. When do mapping it may fail with EBUSY from ioctl(nbd, NBD_DO_IT), but actually the nbd device has already unmaped. It dues to if just after the wake_up(), the recv_work() is scheduled out and defers calling the nbd_config_put(), though the map process has exited the "nbd->recv_task" is not cleared. Signed-off-by: Xiubo Li <xiubli@redhat.com> Reviewed-by: Josef Bacik <josef@toxicpanda.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>zero-sugar-mainline-defconfig
parent
d8f53b0ab0
commit
87aac3a80a
|
@ -802,9 +802,9 @@ static void recv_work(struct work_struct *work)
|
||||||
if (likely(!blk_should_fake_timeout(rq->q)))
|
if (likely(!blk_should_fake_timeout(rq->q)))
|
||||||
blk_mq_complete_request(rq);
|
blk_mq_complete_request(rq);
|
||||||
}
|
}
|
||||||
|
nbd_config_put(nbd);
|
||||||
atomic_dec(&config->recv_threads);
|
atomic_dec(&config->recv_threads);
|
||||||
wake_up(&config->recv_wq);
|
wake_up(&config->recv_wq);
|
||||||
nbd_config_put(nbd);
|
|
||||||
kfree(args);
|
kfree(args);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue