iio: fix error return code
Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
parent
d7b79519fa
commit
889c558095
|
@ -1201,12 +1201,16 @@ static int xadc_probe(struct platform_device *pdev)
|
||||||
goto err_device_free;
|
goto err_device_free;
|
||||||
|
|
||||||
xadc->convst_trigger = xadc_alloc_trigger(indio_dev, "convst");
|
xadc->convst_trigger = xadc_alloc_trigger(indio_dev, "convst");
|
||||||
if (IS_ERR(xadc->convst_trigger))
|
if (IS_ERR(xadc->convst_trigger)) {
|
||||||
|
ret = PTR_ERR(xadc->convst_trigger);
|
||||||
goto err_triggered_buffer_cleanup;
|
goto err_triggered_buffer_cleanup;
|
||||||
|
}
|
||||||
xadc->samplerate_trigger = xadc_alloc_trigger(indio_dev,
|
xadc->samplerate_trigger = xadc_alloc_trigger(indio_dev,
|
||||||
"samplerate");
|
"samplerate");
|
||||||
if (IS_ERR(xadc->samplerate_trigger))
|
if (IS_ERR(xadc->samplerate_trigger)) {
|
||||||
|
ret = PTR_ERR(xadc->samplerate_trigger);
|
||||||
goto err_free_convst_trigger;
|
goto err_free_convst_trigger;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
xadc->clk = devm_clk_get(&pdev->dev, NULL);
|
xadc->clk = devm_clk_get(&pdev->dev, NULL);
|
||||||
|
|
Loading…
Reference in a new issue