redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

drm: rcar-du: Convert rcar_du_encoders_init_one() return value to 0/<0

Browse source 
The function returns 1 on success, and either 0 or a negative error code
on failure. As the 0 and negative values don't need to be differentiated
by the caller, convert it to the usual scheme of returning 0 on success
and a negative error code on failure.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2015-05-26 15:07:56 +03:00
parent 64549cdf85
commit 898a2f387d
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/gpu/drm/rcar-du/rcar_du_kms.c
View file

@ -573,7 +573,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
if (!entity) { if (!entity) {
dev_dbg(rcdu->dev, "unconnected endpoint %s, skipping\n", dev_dbg(rcdu->dev, "unconnected endpoint %s, skipping\n",
ep->local_node->full_name); ep->local_node->full_name);
return 0; return -ENODEV;
} }
entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 0); entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 0);
@ -596,7 +596,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
encoder->full_name); encoder->full_name);
of_node_put(entity_ep_node); of_node_put(entity_ep_node);
of_node_put(encoder); of_node_put(encoder);
return 0; return -ENODEV;
} }
break; break;
@ -625,7 +625,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
encoder->full_name); encoder->full_name);
of_node_put(encoder); of_node_put(encoder);
of_node_put(connector); of_node_put(connector);
return 0; return -EINVAL;
} }
} else { } else {
/* /*
@ -644,7 +644,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
"failed to initialize encoder %s (%d), skipping\n", "failed to initialize encoder %s (%d), skipping\n",
encoder->full_name, ret); encoder->full_name, ret);
return ret < 0 ? ret : 1; return ret;
} }
static int rcar_du_encoders_init(struct rcar_du_device *rcdu) static int rcar_du_encoders_init(struct rcar_du_device *rcdu)
@ -696,7 +696,7 @@ static int rcar_du_encoders_init(struct rcar_du_device *rcdu)
continue; continue;
} }
num_encoders += ret; num_encoders++;
} }
return num_encoders; return num_encoders;