redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

drm/i915/ddi: use switch case instead of if ladder for ddi_get_encoder_port

Browse source 
Make the alternatives stand  out better.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Jani Nikula 2015-09-29 10:24:26 +03:00 committed by Daniel Vetter
parent 85b98a4c30
commit 8cd21b7f28
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
drivers/gpu/drm/i915/intel_ddi.c
View file

@ -309,20 +309,26 @@ static void ddi_get_encoder_port(struct intel_encoder *intel_encoder,
enum port *port) enum port *port)
{ {
struct drm_encoder *encoder = &intel_encoder->base; struct drm_encoder *encoder = &intel_encoder->base;
int type = intel_encoder->type;
if (type == INTEL_OUTPUT_DP_MST) { switch (intel_encoder->type) {
case INTEL_OUTPUT_DP_MST:
*dig_port = enc_to_mst(encoder)->primary; *dig_port = enc_to_mst(encoder)->primary;
*port = (*dig_port)->port; *port = (*dig_port)->port;
} else if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP || break;
type == INTEL_OUTPUT_HDMI || type == INTEL_OUTPUT_UNKNOWN) { case INTEL_OUTPUT_DISPLAYPORT:
case INTEL_OUTPUT_EDP:
case INTEL_OUTPUT_HDMI:
case INTEL_OUTPUT_UNKNOWN:
*dig_port = enc_to_dig_port(encoder); *dig_port = enc_to_dig_port(encoder);
*port = (*dig_port)->port; *port = (*dig_port)->port;
} else if (type == INTEL_OUTPUT_ANALOG) { break;
case INTEL_OUTPUT_ANALOG:
*dig_port = NULL; *dig_port = NULL;
*port = PORT_E; *port = PORT_E;
} else { break;
WARN(1, "Invalid DDI encoder type %d\n", type); default:
WARN(1, "Invalid DDI encoder type %d\n", intel_encoder->type);
break;
} }
} }