netdevsim: fix unbalaced locking in nsim_create()
[ Upstream commit5.4-rM2-2.2.x-imx-squashed2c9d8e01f0
] In the nsim_create(), rtnl_lock() is called before nsim_bpf_init(). If nsim_bpf_init() is failed, rtnl_unlock() should be called, but it isn't called. So, unbalanced locking would occur. Fixes:e05b2d141f
("netdevsim: move netdev creation/destruction to dev probe") Signed-off-by: Taehee Yoo <ap420073@gmail.com> Reviewed-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
parent
99a5e865cb
commit
8d416c038a
|
@ -301,7 +301,7 @@ nsim_create(struct nsim_dev *nsim_dev, struct nsim_dev_port *nsim_dev_port)
|
||||||
rtnl_lock();
|
rtnl_lock();
|
||||||
err = nsim_bpf_init(ns);
|
err = nsim_bpf_init(ns);
|
||||||
if (err)
|
if (err)
|
||||||
goto err_free_netdev;
|
goto err_rtnl_unlock;
|
||||||
|
|
||||||
nsim_ipsec_init(ns);
|
nsim_ipsec_init(ns);
|
||||||
|
|
||||||
|
@ -315,8 +315,8 @@ nsim_create(struct nsim_dev *nsim_dev, struct nsim_dev_port *nsim_dev_port)
|
||||||
err_ipsec_teardown:
|
err_ipsec_teardown:
|
||||||
nsim_ipsec_teardown(ns);
|
nsim_ipsec_teardown(ns);
|
||||||
nsim_bpf_uninit(ns);
|
nsim_bpf_uninit(ns);
|
||||||
|
err_rtnl_unlock:
|
||||||
rtnl_unlock();
|
rtnl_unlock();
|
||||||
err_free_netdev:
|
|
||||||
free_netdev(dev);
|
free_netdev(dev);
|
||||||
return ERR_PTR(err);
|
return ERR_PTR(err);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue