redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: complete overflow responses

Browse source 
If a response arrives for an operation request and the allotted
buffer isn't big enough we report the error, but we don't finish
processing the response.

Instead, set the operation result, but then finish processing
the response (no different from any other operation error).

This will allow the normal completion handling to occur for
this error case.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Alex Elder 2014-11-20 15:37:07 -06:00 committed by Greg Kroah-Hartman
parent e8b48d1586
commit 8d55f4c6d9
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
drivers/staging/greybus/operation.c
View file

@ -526,16 +526,15 @@ static void gb_connection_recv_response(struct gb_connection *connection,
gb_pending_operation_remove(operation);
message = &operation->response;
if (size > message->buffer_size) {
operation->result = GB_OP_OVERFLOW;
if (size <= message->buffer_size) {
/* Transfer the operation result from the response header */
header = message->buffer;
operation->result = header->result;
} else {
gb_connection_err(connection, "recv buffer too small");
return; /* XXX Should still complete operation */
operation->result = GB_OP_OVERFLOW;
}
/* The status in the response is the result of the operation */
header = message->buffer;
operation->result = header->result;
/* We must ignore the payload if a bad status is returned */
if (operation->result == GB_OP_SUCCESS)
memcpy(message->buffer, data, size);