1
0
Fork 0

tools/testing/selftests/sysctl/sysctl.sh: ignore diff output on verify_diff_w()

When verify_diff_w() is used we care about the result, not the verbose
output, and although we use -q, that still gives us a chatty message
about if the files differ or not.  Since verify_diff_w() uses stdinput
the chatty message says whether or not "-" matches the target file, and
this just seems rather odd.  Better to just ignore that messsage all
together, what we really care about i sthe results, the return value and
we check for that.

Link: http://lkml.kernel.org/r/20190320222831.8243-4-mcgrof@kernel.org
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: Eric Sandeen <sandeen@redhat.com>
Cc: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
hifive-unleashed-5.2
Luis Chamberlain 2019-05-14 15:45:04 -07:00 committed by Linus Torvalds
parent 5a12928ea8
commit 8ded3d1026
1 changed files with 1 additions and 1 deletions

View File

@ -179,7 +179,7 @@ verify()
verify_diff_w()
{
echo "$TEST_STR" | diff -q -w -u - $1
echo "$TEST_STR" | diff -q -w -u - $1 > /dev/null
return $?
}