redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

hwrng: Fix unsigned comparison with less than zero 

The return from the call to tee_client_invoke_func can be a
negative error code however this is being assigned to an
unsigned variable 'ret' hence the check is always false.
Fix this by making 'ret' an int.

Detected by Coccinelle ("Unsigned expression compared with zero:
ret < 0")

Fixes: 5fe8b1cc6a ("hwrng: add OP-TEE based rng driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
hifive-unleashed-5.1
YueHaibing 2019-02-19 14:33:02 +08:00 committed by Arnd Bergmann
parent bb342f0168
commit 8deed84744
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/char/hw_random/optee-rng.c
View File

@ -73,7 +73,7 @@ struct optee_rng_private {
static size_t get_optee_rng_data(struct optee_rng_private *pvt_data,
void *buf, size_t req_size)
{
u32 ret = 0;
int ret = 0;
u8 *rng_data = NULL;
size_t rng_size = 0;
struct tee_ioctl_invoke_arg inv_arg;
@ -175,7 +175,7 @@ static struct optee_rng_private pvt_data = {
static int get_optee_rng_info(struct device *dev)
{
u32 ret = 0;
int ret = 0;
struct tee_ioctl_invoke_arg inv_arg;
struct tee_param param[4];