redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: connection: fix locking in gb_hd_connection_find 

Fix unconditional re-enabling of interrupts in gb_hd_connection_find,
which can be called with local interrupts disabled from the USB
completion handler.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
hifive-unleashed-5.1
Johan Hovold 2015-03-02 09:55:26 +01:00 committed by Greg Kroah-Hartman
parent d1b20d72ae
commit 8f5eadb7ea
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/greybus/connection.c
View File

@ -18,14 +18,15 @@ struct gb_connection *gb_hd_connection_find(struct greybus_host_device *hd,
u16 cport_id)
{
struct gb_connection *connection = NULL;
unsigned long flags;
spin_lock_irq(&gb_connections_lock);
spin_lock_irqsave(&gb_connections_lock, flags);
list_for_each_entry(connection, &hd->connections, hd_links)
if (connection->hd_cport_id == cport_id)
goto found;
connection = NULL;
found:
spin_unlock_irq(&gb_connections_lock);
spin_unlock_irqrestore(&gb_connections_lock, flags);
return connection;
}