redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: wilc1000: change handle_get_ip_address's return type to void

Browse source 
When handle_get_ip_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due to have
a single statement.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Chaehyun Lim 2016-05-02 19:47:49 +09:00 committed by Greg Kroah-Hartman
parent 99aded71b5
commit 8f9d9e0041
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/staging/wilc1000/host_interface.c
View file

@ -374,7 +374,7 @@ static void handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)
netdev_err(vif->ndev, "Failed to set IP address\n"); netdev_err(vif->ndev, "Failed to set IP address\n");
} }
static s32 handle_get_ip_address(struct wilc_vif *vif, u8 idx) static void handle_get_ip_address(struct wilc_vif *vif, u8 idx)
{ {
s32 result = 0; s32 result = 0;
struct wid wid; struct wid wid;
@ -394,12 +394,8 @@ static s32 handle_get_ip_address(struct wilc_vif *vif, u8 idx)
if (memcmp(get_ip[idx], set_ip[idx], IP_ALEN) != 0) if (memcmp(get_ip[idx], set_ip[idx], IP_ALEN) != 0)
wilc_setup_ipaddress(vif, set_ip[idx], idx); wilc_setup_ipaddress(vif, set_ip[idx], idx);
if (result != 0) { if (result != 0)
netdev_err(vif->ndev, "Failed to get IP address\n"); netdev_err(vif->ndev, "Failed to get IP address\n");
return -EINVAL;
}
return result;
} }
static s32 handle_get_mac_address(struct wilc_vif *vif, static s32 handle_get_mac_address(struct wilc_vif *vif,