redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

bus: bt1-axi: Use sysfs_streq instead of strncmp 

There is a ready-to-use method to compare a retrieved from a sysfs node
string with another string. It treats both NUL and newline-then-NUL as
equivalent string terminations. So use it instead of manually truncating
the line length in the strncmp() method.

Link: https://lore.kernel.org/r/20200528145050.5203-6-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Olof Johansson <olof@lixom.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: soc@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
alistair/sunxi64-5.8
Serge Semin 2020-05-28 17:50:50 +03:00 committed by Arnd Bergmann
parent 7f57416f2a
commit 9192008853
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/bus/bt1-axi.c
View File

@ -220,9 +220,9 @@ static ssize_t inject_error_store(struct device *dev,
* error while unaligned writing - the AXI bus write error handled
* by this driver.
*/
if (!strncmp(data, "bus", 3))
if (sysfs_streq(data, "bus"))
readb(axi->qos_regs);
else if (!strncmp(data, "unaligned", 9))
else if (sysfs_streq(data, "unaligned"))
writeb(0, axi->qos_regs);
else
return -EINVAL;