redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

IB/core: Use memdup_user() rather than duplicating its implementation 

* Reuse existing functionality from memdup_user() instead of keeping
  duplicate source code.

  This issue was detected by using the Coccinelle software.

* The local variable "ret" will be set to an appropriate value a bit later.
  Thus omit the explicit initialisation at the beginning.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Doug Ledford <dledford@redhat.com>
hifive-unleashed-5.1
Markus Elfring 2016-08-22 18:23:24 +02:00 committed by Doug Ledford
parent 48ef5865d0
commit 92d27ae6b3
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
include/rdma/ib_verbs.h
View File

@ -2115,22 +2115,17 @@ static inline bool ib_is_udata_cleared(struct ib_udata *udata,
size_t len)
{
const void __user *p = udata->inbuf + offset;
bool ret = false;
bool ret;
u8 *buf;
if (len > USHRT_MAX)
return false;
buf = kmalloc(len, GFP_KERNEL);
if (!buf)
buf = memdup_user(p, len);
if (IS_ERR(buf))
return false;
if (copy_from_user(buf, p, len))
goto free;
ret = !memchr_inv(buf, 0, len);
free:
kfree(buf);
return ret;
}