redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

media: vpu_windsor: fix boot warning by intialize device_caps 

Caused by:
049e684 media: v4l2-dev: fix WARN_ON(!vdev->device_caps)
3c13505 media: v4l2-dev/ioctl: require non-zero device_caps, verify sane querycap results

[    1.672018] WARNING: CPU: 0 PID: 61 at ../drivers/media/v4l2-core/v4l2-dev.c:864 __video_register_device+0x70/0x1524
[    1.682454] Modules linked in:
[    1.685501] CPU: 0 PID: 61 Comm: kworker/0:1 Not tainted 5.3.0-rc2-next-20190730-01100-gb0d5e17 #476
[    1.694617] Hardware name: Freescale i.MX8QXP MEK (DT)
[    1.699751] Workqueue: events deferred_probe_work_func
[    1.704870] pstate: 60000005 (nZCv daif -PAN -UAO)
[    1.709647] pc : __video_register_device+0x70/0x1524
[    1.714603] lr : __video_register_device+0x70/0x1524
[    1.719550] sp : ffff00001207ba70
[    1.722849] x29: ffff00001207ba70 x28: ffff00001005bcd8
[    1.728148] x27: ffff80083b4e23b8 x26: ffff0000119a0230
[    1.733448] x25: ffff80083af4d800 x24: 0000000000000001
[    1.738747] x23: 0000000000000000 x22: ffff80083bfc7c10
[    1.744046] x21: ffff80083fa285c0 x20: ffff000011041d90
[    1.749346] x19: ffff000011989000 x18: ffff000014ffffff
[    1.754645] x17: 0000000037cab0d3 x16: ffff000014ffffff
[    1.759945] x15: ffff0000113e6000 x14: 0000008000000000
[    1.765244] x13: 0000000000000000 x12: 00000000000000e9
[    1.770543] x11: ffffffffffffffff x10: 00000000000000ea
[    1.775843] x9 : ffff0000119a34c0 x8 : 5d20657265682074
[    1.781142] x7 : 7563205b2d2d2d2d x6 : ffff0000106dc978
[    1.786441] x5 : 0000000000000000 x4 : 0000000000000000
[    1.791741] x3 : 00000000ffffffff x2 : 1e3af7ec181d8600
[    1.797040] x1 : 0000000000000000 x0 : 0000000000000024
[    1.802342] Call trace:
[    1.804779]  __video_register_device+0x70/0x1524
[    1.809383]  vpu_enc_probe+0x290/0xb94
[    1.813117]  platform_drv_probe+0x4c/0xb0
[    1.817112]  really_probe+0x1c4/0x2d0
[    1.820761]  driver_probe_device+0x58/0xfc
[    1.824842]  __device_attach_driver+0x90/0xac
[    1.829190]  bus_for_each_drv+0x68/0xbc
[    1.833008]  __device_attach+0xe0/0x138
[    1.836831]  device_initial_probe+0x10/0x18
[    1.841000]  bus_probe_device+0x90/0x98
[    1.844823]  deferred_probe_work_func+0x70/0xa4
[    1.849346]  process_one_work+0x13c/0x2b4
[    1.853337]  worker_thread+0x35c/0x3e4
[    1.857077]  kthread+0xf8/0x124
[    1.860204]  ret_from_fork+0x10/0x18

Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
5.4-rM2-2.2.x-imx-squashed
Dong Aisheng 2019-07-31 20:24:18 +08:00
parent 5ae24aba1c
commit 92e1bbb20a
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mxc/vpu_windsor/vpu_encoder_b0.c
View File

@ -4965,6 +4965,11 @@ static int create_vpu_video_device(struct vpu_dev *dev)
dev->pvpu_encoder_dev->release = video_device_release;
dev->pvpu_encoder_dev->vfl_dir = vpu_enc_v4l2_videodevice.vfl_dir;
dev->pvpu_encoder_dev->v4l2_dev = &dev->v4l2_dev;
dev->pvpu_encoder_dev->device_caps = V4L2_CAP_VIDEO_M2M_MPLANE |
V4L2_CAP_STREAMING |
V4L2_CAP_VIDEO_CAPTURE_MPLANE |
V4L2_CAP_VIDEO_OUTPUT_MPLANE;
video_set_drvdata(dev->pvpu_encoder_dev, dev);
ret = video_register_device(dev->pvpu_encoder_dev,