redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

hinic: Use devm_kasprintf instead of hard coding it 

'devm_kasprintf' is less verbose than:
   snprintf(NULL, 0, ...);
   devm_kzalloc(...);
   sprintf
so use it instead.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Zhao Chen <zhaochen6@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
alistair/sunxi64-5.4-dsi
Christophe JAILLET 2019-06-13 21:54:12 +02:00 committed by David S. Miller
parent 407308f60d
commit 930cfe0f12
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/huawei/hinic/hinic_rx.c
View File

@ -502,7 +502,7 @@ int hinic_init_rxq(struct hinic_rxq *rxq, struct hinic_rq *rq,
struct net_device *netdev)
{
struct hinic_qp *qp = container_of(rq, struct hinic_qp, rq);
int err, pkts, irqname_len;
int err, pkts;
rxq->netdev = netdev;
rxq->rq = rq;
@ -511,13 +511,11 @@ int hinic_init_rxq(struct hinic_rxq *rxq, struct hinic_rq *rq,
rxq_stats_init(rxq);
irqname_len = snprintf(NULL, 0, "hinic_rxq%d", qp->q_id) + 1;
rxq->irq_name = devm_kzalloc(&netdev->dev, irqname_len, GFP_KERNEL);
rxq->irq_name = devm_kasprintf(&netdev->dev, GFP_KERNEL,
"hinic_rxq%d", qp->q_id);
if (!rxq->irq_name)
return -ENOMEM;
sprintf(rxq->irq_name, "hinic_rxq%d", qp->q_id);
pkts = rx_alloc_pkts(rxq);
if (!pkts) {
err = -ENOMEM;