redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

i2c: dln2: Simplify return flow for dln2_i2c_enable 

This fixes the following kbuild test robot warning:

>> drivers/i2c/busses/i2c-dln2.c:70:1-4: WARNING: end returns can be simplified if negative or 0 value

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
hifive-unleashed-5.1
Octavian Purdila 2014-11-18 14:57:58 +02:00 committed by Lee Jones
parent 7ca2b1c672
commit 9331642812
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/i2c/busses/i2c-dln2.c
View File

@ -54,7 +54,6 @@ struct dln2_i2c {
static int dln2_i2c_enable(struct dln2_i2c *dln2, bool enable)
{
int ret;
u16 cmd;
struct {
u8 port;
@ -67,11 +66,7 @@ static int dln2_i2c_enable(struct dln2_i2c *dln2, bool enable)
else
cmd = DLN2_I2C_DISABLE;
ret = dln2_transfer_tx(dln2->pdev, cmd, &tx, sizeof(tx));
if (ret < 0)
return ret;
return 0;
return dln2_transfer_tx(dln2->pdev, cmd, &tx, sizeof(tx));
}
static int dln2_i2c_write(struct dln2_i2c *dln2, u8 addr,