redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

iavf: Fix updating statistics 

Commit bac8486116 ("iavf: Refactor the watchdog state machine") inverted
the logic for when to update statistics. Statistics should be updated when
no other commands are pending, instead they were only requested when a
command was processed. iavf_request_stats() would see a pending request
and not request statistics to be updated. This caused statistics to never
be updated; fix the logic.

Fixes: bac8486116 ("iavf: Refactor the watchdog state machine")
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
zero-sugar-mainline-defconfig
Tony Nguyen 2020-06-24 09:04:22 -07:00
parent 44ea803e2f
commit 9358076642
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/intel/iavf/iavf_main.c
View File

@ -1937,7 +1937,10 @@ static void iavf_watchdog_task(struct work_struct *work)
iavf_send_api_ver(adapter);
}
} else {
if (!iavf_process_aq_command(adapter) &&
/* An error will be returned if no commands were
* processed; use this opportunity to update stats
*/
if (iavf_process_aq_command(adapter) &&
adapter->state == __IAVF_RUNNING)
iavf_request_stats(adapter);
}