kernfs: do not call fsnotify() with name without a parent
[ Upstream commit5.4-rM2-2.2.x-imx-squashed9991bb84b2
] When creating an FS_MODIFY event on inode itself (not on parent) the file_name argument should be NULL. The change to send a non NULL name to inode itself was done on purpuse as part of another commit, as Tejun writes: "...While at it, supply the target file name to fsnotify() from kernfs_node->name.". But this is wrong practice and inconsistent with inotify behavior when watching a single file. When a child is being watched (as opposed to the parent directory) the inotify event should contain the watch descriptor, but not the file name. Fixes:df6a58c5c5
("kernfs: don't depend on d_find_any_alias()...") Link: https://lore.kernel.org/r/20200708111156.24659-5-amir73il@gmail.com Acked-by: Tejun Heo <tj@kernel.org> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Sasha Levin <sashal@kernel.org>
parent
b7fc8591ca
commit
936e927ece
|
@ -912,7 +912,7 @@ repeat:
|
|||
}
|
||||
|
||||
fsnotify(inode, FS_MODIFY, inode, FSNOTIFY_EVENT_INODE,
|
||||
&name, 0);
|
||||
NULL, 0);
|
||||
iput(inode);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue