redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drm/i915: Stop kicking the signaling thread on seqno wraparound 

Since commit fd10e2ce99 ("drm/i915/breadcrumbs: Ignore unsubmitted
signalers"), we cancel the signaler when retiring the request and so
upon wraparound, where we wait for all requests to be retired, we no
longer need to spin waiting for the signaling thread to release its
references to the in-flight requests, and so we can assert that the
signaler is idle.

References: fd10e2ce99 ("drm/i915/breadcrumbs: Ignore unsubmitted signalers")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180306130143.13312-1-chris@chris-wilson.co.uk
hifive-unleashed-5.1
Chris Wilson 2018-03-06 13:01:42 +00:00
parent 9792e213a4
commit 93eef7d653
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/i915/i915_request.c
View File

@ -220,6 +220,8 @@ static int reset_all_global_seqno(struct drm_i915_private *i915, u32 seqno)
/* spin until threads are complete */
while (intel_breadcrumbs_busy(engine))
cond_resched();
GEM_BUG_ON(!list_empty(&engine->breadcrumbs.signals));
}
/* Check we are idle before we fiddle with hw state! */

5
drivers/gpu/drm/i915/intel_breadcrumbs.c
View File

@ -889,11 +889,6 @@ bool intel_breadcrumbs_busy(struct intel_engine_cs *engine)
spin_unlock_irq(&b->irq_lock);
}
if (!busy && !list_empty(&b->signals)) {
wake_up_process(b->signaler);
busy = true;
}
return busy;
}