cxgb4: allow large buffer size to have page size
Since commit 52367a763d
("cxgb4/cxgb4vf: Code cleanup to enable T4 Configuration File support"),
we have failures like this during cxgb4 probe:
cxgb4 0000:01:00.4: bad SGE FL page buffer sizes [65536, 65536]
cxgb4: probe of 0000:01:00.4 failed with error -22
This happens whenever software parameters are used, without a
configuration file. That happens when the hardware was already
initialized (after kexec, or after csiostor is loaded).
It happens that these values are acceptable, rendering fl_pg_order equal
to 0, which is the case of a hard init when the page size is equal or
larger than 65536.
Accepting fl_large_pg equal to fl_small_pg solves the issue, and
shouldn't cause any trouble besides a possible performance reduction
when smaller pages are used. And that can be fixed by a configuration
file.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
aca5f58f9b
commit
940d9d34a5
|
@ -2581,7 +2581,7 @@ static int t4_sge_init_soft(struct adapter *adap)
|
|||
#undef READ_FL_BUF
|
||||
|
||||
if (fl_small_pg != PAGE_SIZE ||
|
||||
(fl_large_pg != 0 && (fl_large_pg <= fl_small_pg ||
|
||||
(fl_large_pg != 0 && (fl_large_pg < fl_small_pg ||
|
||||
(fl_large_pg & (fl_large_pg-1)) != 0))) {
|
||||
dev_err(adap->pdev_dev, "bad SGE FL page buffer sizes [%d, %d]\n",
|
||||
fl_small_pg, fl_large_pg);
|
||||
|
|
Loading…
Reference in a new issue