redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

gpio: tb10x: fix return value check in tb10x_gpio_probe() 

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR(). Also remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
hifive-unleashed-5.1
Wei Yongjun 2013-10-30 11:09:15 +08:00 committed by Linus Walleij
parent 85aa391528
commit 9a4864c897
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpio/gpio-tb10x.c
View File

@ -207,10 +207,8 @@ static int tb10x_gpio_probe(struct platform_device *pdev)
spin_lock_init(&tb10x_gpio->spinlock);
tb10x_gpio->base = devm_ioremap_resource(&pdev->dev, mem);
if (!tb10x_gpio->base) {
dev_err(&pdev->dev, "Could not remap reg space.\n");
goto fail_ioremap;
}
if (IS_ERR(tb10x_gpio->base))
return PTR_ERR(tb10x_gpio->base);
tb10x_gpio->gc.label = of_node_full_name(dn);
tb10x_gpio->gc.dev = &pdev->dev;