redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ipmi: avoid atomic_inc in exit function 

This causes a link failure on ARM in certain configurations,
when we reference each atomic operation from .alt.smp.init in
order to patch out atomics on non-SMP systems:

`.exit.text' referenced in section `.alt.smp.init' of drivers/char/ipmi/ipmi_msghandler.o: defined in discarded section `.exit.text' of drivers/char/ipmi/ipmi_msghandler.o

In this case, we can trivially replace the atomic_inc() with
an atomic_set() that has the same effect and does not require
a fixup.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Message-Id: <20190415155509.3565087-1-arnd@arndb.de>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
hifive-unleashed-5.2
Arnd Bergmann 2019-04-15 17:55:00 +02:00 committed by Corey Minyard
parent 8fac128ce9
commit 9a75bd18a8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/char/ipmi/ipmi_msghandler.c
View File

@ -5179,7 +5179,7 @@ static void __exit cleanup_ipmi(void)
* avoids problems with race conditions removing the timer
* here.
*/
atomic_inc(&stop_operation);
atomic_set(&stop_operation, 1);
del_timer_sync(&ipmi_timer);
initialized = false;