redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

NetCP: Deletion of unnecessary checks before two function calls 

The functions cpsw_ale_destroy() and of_dev_put() test whether their argument
is NULL and then return immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
hifive-unleashed-5.1
Markus Elfring 2015-02-03 20:12:25 +01:00 committed by David S. Miller
parent f339664c0b
commit 9b55669c14
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/ti/netcp_ethss.c
View File

@ -2011,12 +2011,10 @@ static int gbe_probe(struct netcp_device *netcp_device, struct device *dev,
quit:
if (gbe_dev->hw_stats)
devm_kfree(dev, gbe_dev->hw_stats);
if (gbe_dev->ale)
cpsw_ale_destroy(gbe_dev->ale);
cpsw_ale_destroy(gbe_dev->ale);
if (gbe_dev->ss_regs)
devm_iounmap(dev, gbe_dev->ss_regs);
if (interfaces)
of_node_put(interfaces);
of_node_put(interfaces);
devm_kfree(dev, gbe_dev);
return ret;
}