redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

Input: sentelic - silence some underflow warnings 

I have a static checker that complains when we check for an upper bound
but don't have a corresponding check for a lower bound.  With this code,
the upper bound check seems not really required, so it is not a bug to
leave the lower bound check out as well.  But let's silence the warning
by making these variables unsigned.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
hifive-unleashed-5.1
Dan Carpenter 2015-08-21 09:29:50 -07:00 committed by Dmitry Torokhov
parent 012bd2a533
commit 9c8f55798a
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/input/mouse/sentelic.c
View File

@ -432,7 +432,7 @@ static int fsp_onpad_hscr(struct psmouse *psmouse, bool enable)
static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,
const char *buf, size_t count)
{
int reg, val;
unsigned int reg, val;
char *rest;
ssize_t retval;
@ -440,7 +440,7 @@ static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,
if (rest == buf || *rest != ' ' || reg > 0xff)
return -EINVAL;
retval = kstrtoint(rest + 1, 16, &val);
retval = kstrtouint(rest + 1, 16, &val);
if (retval)
return retval;
@ -476,9 +476,10 @@ static ssize_t fsp_attr_set_getreg(struct psmouse *psmouse, void *data,
const char *buf, size_t count)
{
struct fsp_data *pad = psmouse->private;
int reg, val, err;
unsigned int reg, val;
int err;
err = kstrtoint(buf, 16, &reg);
err = kstrtouint(buf, 16, &reg);
if (err)
return err;
@ -511,9 +512,10 @@ static ssize_t fsp_attr_show_pagereg(struct psmouse *psmouse,
static ssize_t fsp_attr_set_pagereg(struct psmouse *psmouse, void *data,
const char *buf, size_t count)
{
int val, err;
unsigned int val;
int err;
err = kstrtoint(buf, 16, &val);
err = kstrtouint(buf, 16, &val);
if (err)
return err;