redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

perf, trace: Fix module leak

Browse source 
Commit 1c024eca (perf, trace: Optimize tracepoints by using
per-tracepoint-per-cpu hlist to track events) caused a module
refcount leak.

Reported-And-Tested-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <4C7E1F12.8030304@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Li Zefan 2010-09-01 12:58:43 +02:00 committed by Ingo Molnar
parent da34634fd3
commit 9cb627d5f3
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
kernel/trace/trace_event_perf.c
View file

@ -91,6 +91,8 @@ int perf_trace_init(struct perf_event *p_event)
tp_event->class && tp_event->class->reg && tp_event->class && tp_event->class->reg &&
try_module_get(tp_event->mod)) { try_module_get(tp_event->mod)) {
ret = perf_trace_event_init(tp_event, p_event); ret = perf_trace_event_init(tp_event, p_event);
if (ret)
module_put(tp_event->mod);
break; break;
} }
} }
@ -146,6 +148,7 @@ void perf_trace_destroy(struct perf_event *p_event)
} }
} }
out: out:
module_put(tp_event->mod);
mutex_unlock(&event_mutex); mutex_unlock(&event_mutex);
} }