redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

selinux: remove useless assignments 

The code incorrectly assigned directly to the variables instead of the
values they point to. Since the values are already set to NULL/0 at the
beginning of the function, we can simply remove these useless
assignments.

Reported-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Fixes: fede148324 ("selinux: log invalid contexts in AVCs")
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
[PM: removed a bad comment that was causing compiler warnings]
Signed-off-by: Paul Moore <paul@paul-moore.com>
hifive-unleashed-5.2
Ondrej Mosnacek 2019-03-25 09:11:15 +01:00 committed by Paul Moore
parent 24f7c45fdb
commit 9e0cfe28fa
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
security/selinux/ss/services.c
View File

@ -1318,14 +1318,11 @@ static int security_sid_to_context_core(struct selinux_state *state,
rc = -EINVAL;
goto out_unlock;
}
if (only_invalid && !context->len) {
scontext = NULL;
scontext_len = 0;
if (only_invalid && !context->len)
rc = 0;
} else {
else
rc = context_struct_to_string(policydb, context, scontext,
scontext_len);
}
out_unlock:
read_unlock(&state->ss->policy_rwlock);
out: