redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

ASoC: sh/fsi: Make one-bit bitfields unsigned

Browse source 
One-bit signed bitfields have two possible values: 0 and -1. This sometimes
leads to unexpected results (e.g. foo.bar = 1; foo.bar == 1 => false) which is
why it is recommended to make one-bit bitfields unsigned.

This fixes the following sparse warnings:
	sound/soc/sh/fsi.c:267:25: error: dubious one-bit signed bitfield
	sound/soc/sh/fsi.c:268:22: error: dubious one-bit signed bitfield
	sound/soc/sh/fsi.c:269:20: error: dubious one-bit signed bitfield
	sound/soc/sh/fsi.c:270:28: error: dubious one-bit signed bitfield
	sound/soc/sh/fsi.c:271:26: error: dubious one-bit signed bitfield
	sound/soc/sh/fsi.c:272:25: error: dubious one-bit signed bitfield

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Lars-Peter Clausen 2014-06-19 09:40:31 +02:00 committed by Mark Brown
parent 7171511eae
commit 9f98cd69c1
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
sound/soc/sh/fsi.c
View file

@ -264,12 +264,12 @@ struct fsi_priv {
u32 fmt; u32 fmt;
int chan_num:16; int chan_num:16;
int clk_master:1; unsigned int clk_master:1;
int clk_cpg:1; unsigned int clk_cpg:1;
int spdif:1; unsigned int spdif:1;
int enable_stream:1; unsigned int enable_stream:1;
int bit_clk_inv:1; unsigned int bit_clk_inv:1;
int lr_clk_inv:1; unsigned int lr_clk_inv:1;
}; };
struct fsi_stream_handler { struct fsi_stream_handler {