redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drm/omap: displays: Don't cast dssdev to panel data unnecessarily 

The connect handle of the analog TV and HDMI connectors casts the dssdev
to panel data only to then access fields of the panel data that are also
present in the dssdev. Remove the cast and use dssdev directly.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
hifive-unleashed-5.1
Laurent Pinchart 2018-03-02 22:05:41 +02:00 committed by Tomi Valkeinen
parent eaaedaf6a1
commit a25edf0ea6
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
View File

@ -43,13 +43,12 @@ static const struct videomode tvc_pal_vm = {
static int tvc_connect(struct omap_dss_device *dssdev)
{
struct panel_drv_data *ddata = to_panel_data(dssdev);
struct omap_dss_device *src;
int r;
src = omapdss_of_find_connected_device(ddata->dev->of_node, 0);
src = omapdss_of_find_connected_device(dssdev->dev->of_node, 0);
if (IS_ERR_OR_NULL(src)) {
dev_err(ddata->dev, "failed to find video source\n");
dev_err(dssdev->dev, "failed to find video source\n");
return src ? PTR_ERR(src) : -EINVAL;
}

5
drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
View File

@ -53,13 +53,12 @@ struct panel_drv_data {
static int hdmic_connect(struct omap_dss_device *dssdev)
{
struct panel_drv_data *ddata = to_panel_data(dssdev);
struct omap_dss_device *src;
int r;
src = omapdss_of_find_connected_device(ddata->dev->of_node, 0);
src = omapdss_of_find_connected_device(dssdev->dev->of_node, 0);
if (IS_ERR_OR_NULL(src)) {
dev_err(ddata->dev, "failed to find video source\n");
dev_err(dssdev->dev, "failed to find video source\n");
return src ? PTR_ERR(src) : -EINVAL;
}