redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

net: ethernet: mediatek: remove superfluous local variable for phy address

Browse source 
remove the unused variable for parsing PHY address
and the related logic for sanity test which would
be all already handled done when of_mdiobus_register
was called

Reported-by: Nelson Chang <nelson.chang@mediatek.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Sean Wang 2016-09-22 16:36:15 +08:00 committed by David S. Miller
parent 2364c5c5ec
commit a2b2a19f0f
1 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/net/ethernet/mediatek/mtk_eth_soc.c
View file

@ -226,17 +226,9 @@ static void mtk_phy_link_adjust(struct net_device *dev)
static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac,
struct device_node *phy_node)
{
const __be32 *_addr = NULL;
struct phy_device *phydev;
int phy_mode, addr;
int phy_mode;
_addr = of_get_property(phy_node, "reg", NULL);
if (!_addr || (be32_to_cpu(*_addr) >= 0x20)) {
pr_err("%s: invalid phy address\n", phy_node->name);
return -EINVAL;
}
addr = be32_to_cpu(*_addr);
phy_mode = of_get_phy_mode(phy_node);
if (phy_mode < 0) {
dev_err(eth->dev, "incorrect phy-mode %d\n", phy_mode);