redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging/fwserial: Destruct embedded tty_port on teardown

Browse source 
For TTY drivers that manage the port lifetime, the tty_port should
to be specifically destructed when the port lifetime ends. Now that
a method has been added to do this, use it.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
This commit is contained in:
Peter Hurley 2012-11-27 21:37:11 -05:00 committed by Greg Kroah-Hartman
parent eef6e7b286
commit a321846492
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/staging/fwserial/fwserial.c
View file

@ -955,6 +955,7 @@ static void fwserial_destroy(struct kref *kref)
for (j = 0; j < num_ports; ++j) {
fw_core_remove_address_handler(&ports[j]->rx_handler);
dma_fifo_free(&ports[j]->tx_fifo);
tty_port_destroy(&ports[j]->port);
kfree(ports[j]);
}
kfree(serial);
@ -2369,8 +2370,10 @@ unregister_ttys:
return err;
free_ports:
for (--i; i >= 0; --i)
for (--i; i >= 0; --i) {
tty_port_destroy(&serial->ports[i]->port);
kfree(serial->ports[i]);
}
kfree(serial);
return err;
}