USB: r8a66597: clean up. remove unneeded null checks
td and dev can not be null. Also they are dereferenced in list_for_each_entry_safe and list_for_each before the check happens so we would have an oops if it were possible for them to be null. Found using the smatch static checker. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
fb34d53752
commit
a33279dfd8
|
@ -822,8 +822,6 @@ static void force_dequeue(struct r8a66597 *r8a66597, u16 pipenum, u16 address)
|
|||
return;
|
||||
|
||||
list_for_each_entry_safe(td, next, list, queue) {
|
||||
if (!td)
|
||||
continue;
|
||||
if (td->address != address)
|
||||
continue;
|
||||
|
||||
|
@ -2025,8 +2023,6 @@ static struct r8a66597_device *get_r8a66597_device(struct r8a66597 *r8a66597,
|
|||
struct list_head *list = &r8a66597->child_device;
|
||||
|
||||
list_for_each_entry(dev, list, device_list) {
|
||||
if (!dev)
|
||||
continue;
|
||||
if (dev->usb_address != addr)
|
||||
continue;
|
||||
|
||||
|
|
Loading…
Reference in a new issue