redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

drm: omapdrm: Pass integer source coordinates to omap_plane_mode_set()

Browse source 
The function will convert the Q16 source coordinates to integers, avoid
converting integers to Q16 first and perform the opposite conversion.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2015-01-17 22:31:42 +02:00
parent 2a438c5b4e
commit a350da8be4
3 changed files with 27 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
drivers/gpu/drm/omapdrm/omap_crtc.c
View file

@ -307,10 +307,9 @@ static int omap_crtc_mode_set(struct drm_crtc *crtc,
crtc->primary->crtc = crtc; crtc->primary->crtc = crtc;
return omap_plane_mode_set(crtc->primary, crtc, crtc->primary->fb, return omap_plane_mode_set(crtc->primary, crtc, crtc->primary->fb,
0, 0, mode->hdisplay, mode->vdisplay, 0, 0, mode->hdisplay, mode->vdisplay,
x << 16, y << 16, x, y, mode->hdisplay, mode->vdisplay,
mode->hdisplay << 16, mode->vdisplay << 16, NULL, NULL);
NULL, NULL);
} }
static void omap_crtc_prepare(struct drm_crtc *crtc) static void omap_crtc_prepare(struct drm_crtc *crtc)
@ -334,10 +333,9 @@ static int omap_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y,
struct drm_display_mode *mode = &crtc->mode; struct drm_display_mode *mode = &crtc->mode;
return omap_plane_mode_set(plane, crtc, crtc->primary->fb, return omap_plane_mode_set(plane, crtc, crtc->primary->fb,
0, 0, mode->hdisplay, mode->vdisplay, 0, 0, mode->hdisplay, mode->vdisplay,
x << 16, y << 16, x, y, mode->hdisplay, mode->vdisplay,
mode->hdisplay << 16, mode->vdisplay << 16, NULL, NULL);
NULL, NULL);
} }
static void vblank_cb(void *arg) static void vblank_cb(void *arg)
@ -369,10 +367,9 @@ static void page_flip_worker(struct work_struct *work)
drm_modeset_lock(&crtc->mutex, NULL); drm_modeset_lock(&crtc->mutex, NULL);
omap_plane_mode_set(crtc->primary, crtc, crtc->primary->fb, omap_plane_mode_set(crtc->primary, crtc, crtc->primary->fb,
0, 0, mode->hdisplay, mode->vdisplay, 0, 0, mode->hdisplay, mode->vdisplay,
crtc->x << 16, crtc->y << 16, crtc->x, crtc->y, mode->hdisplay, mode->vdisplay,
mode->hdisplay << 16, mode->vdisplay << 16, vblank_cb, crtc);
vblank_cb, crtc);
drm_modeset_unlock(&crtc->mutex); drm_modeset_unlock(&crtc->mutex);
bo = omap_framebuffer_bo(crtc->primary->fb, 0); bo = omap_framebuffer_bo(crtc->primary->fb, 0);

12
drivers/gpu/drm/omapdrm/omap_drv.h
View file

@ -163,12 +163,12 @@ struct drm_plane *omap_plane_init(struct drm_device *dev,
int id, enum drm_plane_type type); int id, enum drm_plane_type type);
int omap_plane_set_enable(struct drm_plane *plane, bool enable); int omap_plane_set_enable(struct drm_plane *plane, bool enable);
int omap_plane_mode_set(struct drm_plane *plane, int omap_plane_mode_set(struct drm_plane *plane,
struct drm_crtc *crtc, struct drm_framebuffer *fb, struct drm_crtc *crtc, struct drm_framebuffer *fb,
int crtc_x, int crtc_y, int crtc_x, int crtc_y,
unsigned int crtc_w, unsigned int crtc_h, unsigned int crtc_w, unsigned int crtc_h,
uint32_t src_x, uint32_t src_y, unsigned int src_x, unsigned int src_y,
uint32_t src_w, uint32_t src_h, unsigned int src_w, unsigned int src_h,
void (*fxn)(void *), void *arg); void (*fxn)(void *), void *arg);
void omap_plane_install_properties(struct drm_plane *plane, void omap_plane_install_properties(struct drm_plane *plane,
struct drm_mode_object *obj); struct drm_mode_object *obj);
int omap_plane_set_property(struct drm_plane *plane, int omap_plane_set_property(struct drm_plane *plane,

24
drivers/gpu/drm/omapdrm/omap_plane.c
View file

@ -184,12 +184,12 @@ static int omap_plane_apply(struct drm_plane *plane)
} }
int omap_plane_mode_set(struct drm_plane *plane, int omap_plane_mode_set(struct drm_plane *plane,
struct drm_crtc *crtc, struct drm_framebuffer *fb, struct drm_crtc *crtc, struct drm_framebuffer *fb,
int crtc_x, int crtc_y, int crtc_x, int crtc_y,
unsigned int crtc_w, unsigned int crtc_h, unsigned int crtc_w, unsigned int crtc_h,
uint32_t src_x, uint32_t src_y, unsigned int src_x, unsigned int src_y,
uint32_t src_w, uint32_t src_h, unsigned int src_w, unsigned int src_h,
void (*fxn)(void *), void *arg) void (*fxn)(void *), void *arg)
{ {
struct omap_plane *omap_plane = to_omap_plane(plane); struct omap_plane *omap_plane = to_omap_plane(plane);
struct omap_drm_window *win = &omap_plane->win; struct omap_drm_window *win = &omap_plane->win;
@ -199,11 +199,10 @@ int omap_plane_mode_set(struct drm_plane *plane,
win->crtc_w = crtc_w; win->crtc_w = crtc_w;
win->crtc_h = crtc_h; win->crtc_h = crtc_h;
/* src values are in Q16 fixed point, convert to integer: */ win->src_x = src_x;
win->src_x = src_x >> 16; win->src_y = src_y;
win->src_y = src_y >> 16; win->src_w = src_w;
win->src_w = src_w >> 16; win->src_h = src_h;
win->src_h = src_h >> 16;
if (fxn) { if (fxn) {
/* omap_crtc should ensure that a new page flip /* omap_crtc should ensure that a new page flip
@ -243,9 +242,10 @@ static int omap_plane_update(struct drm_plane *plane,
plane->fb = fb; plane->fb = fb;
plane->crtc = crtc; plane->crtc = crtc;
/* src values are in Q16 fixed point, convert to integer: */
return omap_plane_mode_set(plane, crtc, fb, return omap_plane_mode_set(plane, crtc, fb,
crtc_x, crtc_y, crtc_w, crtc_h, crtc_x, crtc_y, crtc_w, crtc_h,
src_x, src_y, src_w, src_h, src_x >> 16, src_y >> 16, src_w >> 16, src_h >> 16,
NULL, NULL); NULL, NULL);
} }