redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

ASoC: rcar: some dubious one-bit signed bitfields

Browse source 
Because these are signed they can either be 0 or -1 instead of 0 and 1
as intended.  It doesn't cause a problem from what I can see, but it's
dangerous and Sparse complains:

	sound/soc/sh/rcar/rsnd.h:177:25:
		error: dubious one-bit signed bitfield

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Dan Carpenter 2013-11-08 12:46:53 +03:00 committed by Mark Brown
parent 324752632a
commit a37377314f
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
sound/soc/sh/rcar/rsnd.h
View file

@ -174,11 +174,11 @@ struct rsnd_dai {
struct rsnd_dai_stream playback;
struct rsnd_dai_stream capture;
int clk_master:1;
int bit_clk_inv:1;
int frm_clk_inv:1;
int sys_delay:1;
int data_alignment:1;
unsigned int clk_master:1;
unsigned int bit_clk_inv:1;
unsigned int frm_clk_inv:1;
unsigned int sys_delay:1;
unsigned int data_alignment:1;
};
#define rsnd_dai_nr(priv) ((priv)->dai_nr)