redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

regulator: qcom-rpm: signedness bug in probe() 

"force_mode" is a u32 so it is never "< 0", but because of type
promotion then comparing "== -1" will do what we want.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
Dan Carpenter 2015-01-28 22:15:31 +03:00 committed by Mark Brown
parent 97bf6af1f9
commit a412ec2795
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/regulator/qcom_rpm-regulator.c
View File

@ -768,7 +768,7 @@ static int rpm_reg_probe(struct platform_device *pdev)
break;
}
if (force_mode < 0) {
if (force_mode == -1) {
dev_err(&pdev->dev, "invalid force mode\n");
return -EINVAL;
}