redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

HID: intel-ish-hid: use put_device() instead of kfree() 

Never directly free @dev after calling device_register(), even
if it returned an error. Always use put_device() to give up the
reference initialized.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
hifive-unleashed-5.1
Arvind Yadav 2018-03-30 16:56:10 +05:30 committed by Jiri Kosina
parent 749ab300d4
commit a4eb490a41
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hid/intel-ish-hid/ishtp/bus.c
View File

@ -418,7 +418,7 @@ static struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev,
list_del(&device->device_link);
spin_unlock_irqrestore(&dev->device_list_lock, flags);
dev_err(dev->devc, "Failed to register ISHTP client device\n");
kfree(device);
put_device(&device->dev);
return NULL;
}