staging: vc04_services: handle kzalloc failure
The kzalloc here was being used without checking the return - if the kzalloc fails return VCHIQ_ERROR. The call-site of vchiq_platform_init_state() vchiq_init_state() was not responding to an allocation failure so checks for != VCHIQ_SUCCESS and pass VCHIQ_ERROR up to vchiq_platform_init() which then will fail with -EINVAL. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Reported-by: kbuild test robot <lkp@intel.com> Acked-By: Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>hifive-unleashed-5.2
parent
f44303e852
commit
a511227787
|
@ -179,6 +179,9 @@ vchiq_platform_init_state(struct vchiq_state *state)
|
||||||
struct vchiq_2835_state *platform_state;
|
struct vchiq_2835_state *platform_state;
|
||||||
|
|
||||||
state->platform_state = kzalloc(sizeof(*platform_state), GFP_KERNEL);
|
state->platform_state = kzalloc(sizeof(*platform_state), GFP_KERNEL);
|
||||||
|
if (!state->platform_state)
|
||||||
|
return VCHIQ_ERROR;
|
||||||
|
|
||||||
platform_state = (struct vchiq_2835_state *)state->platform_state;
|
platform_state = (struct vchiq_2835_state *)state->platform_state;
|
||||||
|
|
||||||
platform_state->inited = 1;
|
platform_state->inited = 1;
|
||||||
|
|
|
@ -2209,6 +2209,8 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero)
|
||||||
local->debug[DEBUG_ENTRIES] = DEBUG_MAX;
|
local->debug[DEBUG_ENTRIES] = DEBUG_MAX;
|
||||||
|
|
||||||
status = vchiq_platform_init_state(state);
|
status = vchiq_platform_init_state(state);
|
||||||
|
if (status != VCHIQ_SUCCESS)
|
||||||
|
return VCHIQ_ERROR;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
bring up slot handler thread
|
bring up slot handler thread
|
||||||
|
|
Loading…
Reference in New Issue