redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

jfs: fix bogus variable self-initialization 

A statement was originally added in 2006 to shut up a gcc warning,
now but now clang warns about it:

fs/jfs/jfs_txnmgr.c:1932:15: error: variable 'pxd' is uninitialized when used within its own initialization
      [-Werror,-Wuninitialized]
                pxd_t pxd = pxd;        /* truncated extent of xad */
                      ~~~   ^~~

Modern versions of gcc are fine without the silly assignment, so just
drop it. Tested with gcc-4.6 (released 2011), 4.7, 4.8, and 4.9.

Fixes: c9e3ad6021 ("JFS: Get rid of "may be used uninitialized" warnings")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
hifive-unleashed-5.2
Arnd Bergmann 2019-03-22 15:19:16 +01:00 committed by Dave Kleikamp
parent 2e3bc61251
commit a5fdd713d2
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/jfs/jfs_txnmgr.c
View File

@ -1928,8 +1928,7 @@ static void xtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
* header ?
*/
if (tlck->type & tlckTRUNCATE) {
/* This odd declaration suppresses a bogus gcc warning */
pxd_t pxd = pxd; /* truncated extent of xad */
pxd_t pxd; /* truncated extent of xad */
int twm;
/*