redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

xfs: fix the same_inode check in xfs_file_share_range 

The VFS i_ino is an unsigned long, while XFS inode numbers are 64-bit
wide, so checking i_ino for equality could lead to rate false positives
on 32-bit architectures.  Just compare the inode pointers themselves
to be safe.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
hifive-unleashed-5.1
Christoph Hellwig 2016-10-20 15:49:03 +11:00 committed by Dave Chinner
parent 4fbc2c6525
commit a62e82b35b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/xfs/xfs_file.c
View File

@ -965,7 +965,7 @@ xfs_file_share_range(
IS_SWAPFILE(inode_out))
return -ETXTBSY;
same_inode = (inode_in->i_ino == inode_out->i_ino);
same_inode = (inode_in == inode_out);
/* Don't reflink dirs, pipes, sockets... */
if (S_ISDIR(inode_in->i_mode) || S_ISDIR(inode_out->i_mode))