ALSA: compress: Don't allow paritial drain operations on capture streams
Partial drain and next track are intended for gapless playback and don't really have an obvious interpretation for a capture stream, so makes sense to not allow those operations on capture streams. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Acked-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>alistair/sunxi64-5.4-dsi
parent
26c3f1542f
commit
a70ab8a864
|
@ -834,6 +834,10 @@ static int snd_compr_next_track(struct snd_compr_stream *stream)
|
||||||
if (stream->runtime->state != SNDRV_PCM_STATE_RUNNING)
|
if (stream->runtime->state != SNDRV_PCM_STATE_RUNNING)
|
||||||
return -EPERM;
|
return -EPERM;
|
||||||
|
|
||||||
|
/* next track doesn't have any meaning for capture streams */
|
||||||
|
if (stream->direction == SND_COMPRESS_CAPTURE)
|
||||||
|
return -EPERM;
|
||||||
|
|
||||||
/* you can signal next track if this is intended to be a gapless stream
|
/* you can signal next track if this is intended to be a gapless stream
|
||||||
* and current track metadata is set
|
* and current track metadata is set
|
||||||
*/
|
*/
|
||||||
|
@ -861,6 +865,10 @@ static int snd_compr_partial_drain(struct snd_compr_stream *stream)
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* partial drain doesn't have any meaning for capture streams */
|
||||||
|
if (stream->direction == SND_COMPRESS_CAPTURE)
|
||||||
|
return -EPERM;
|
||||||
|
|
||||||
/* stream can be drained only when next track has been signalled */
|
/* stream can be drained only when next track has been signalled */
|
||||||
if (stream->next_track == false)
|
if (stream->next_track == false)
|
||||||
return -EPERM;
|
return -EPERM;
|
||||||
|
|
Loading…
Reference in New Issue