reset: remove redundant null check on pointer dev
Pointer dev is being dereferenced when passed to the inlined
functon dev_name, however, dev is later being null checked
so at first this seems like a potential null pointer dereference.
In fact, _reset_control_get_from_lookup is only ever called from
__reset_control_get, right after checking dev->of_node hence
dev can never be null. Clean this up by removing the redundant
null check.
Thanks to Philipp Zabel for spotting that dev can never be null.
Addresses-Coverity: ("Dereference before null check")
Fixes: 6691dffab0
("reset: add support for non-DT systems")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
alistair/sunxi64-5.4-dsi
parent
a188339ca5
commit
a71dcd3757
|
@ -694,9 +694,6 @@ __reset_control_get_from_lookup(struct device *dev, const char *con_id,
|
||||||
const char *dev_id = dev_name(dev);
|
const char *dev_id = dev_name(dev);
|
||||||
struct reset_control *rstc = NULL;
|
struct reset_control *rstc = NULL;
|
||||||
|
|
||||||
if (!dev)
|
|
||||||
return ERR_PTR(-EINVAL);
|
|
||||||
|
|
||||||
mutex_lock(&reset_lookup_mutex);
|
mutex_lock(&reset_lookup_mutex);
|
||||||
|
|
||||||
list_for_each_entry(lookup, &reset_lookup_list, list) {
|
list_for_each_entry(lookup, &reset_lookup_list, list) {
|
||||||
|
|
Loading…
Reference in New Issue