redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

[media] media: don't try to empty links list in media_entity_cleanup() 

The media_entity_cleanup() function only cleans up the entity links list
but this operation is already made in media_device_unregister_entity().

In most cases this should be harmless (besides having duplicated code)
since the links list would be empty so the iteration would not happen
but the links list is initialized in media_device_register_entity() so
if a driver fails to register an entity with a media device and clean up
the entity in the error path, a NULL deference pointer error will happen.

So don't try to empty the links list in media_entity_cleanup() since
is either done already or haven't been initialized yet.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
hifive-unleashed-5.1
Javier Martinez Canillas 2015-08-24 14:57:53 -03:00 committed by Mauro Carvalho Chehab
parent 7e9a8ad57c
commit a9709e4354
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/media-entity.c
View File

@ -242,13 +242,6 @@ EXPORT_SYMBOL_GPL(media_entity_init);
void
media_entity_cleanup(struct media_entity *entity)
{
struct media_link *link, *tmp;
list_for_each_entry_safe(link, tmp, &entity->links, list) {
media_gobj_remove(&link->graph_obj);
list_del(&link->list);
kfree(link);
}
}
EXPORT_SYMBOL_GPL(media_entity_cleanup);