redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

fsi: scom: Fix NULL dereference 

The chardev conversion forgot to copy the fsi_dev,
silly mistake, compounded by a testing mistake on
my side, this specific driver wasn't being tested
properly.

Fixes: d8f4587655 "fsi: scom: Convert to use the new chardev"
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
hifive-unleashed-5.1
Benjamin Herrenschmidt 2018-08-06 12:22:37 +10:00
parent 9840fcd8cc
commit aa1221b258
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/fsi/fsi-scom.c
View File

@ -598,6 +598,7 @@ static int scom_probe(struct device *dev)
kfree(scom);
return -ENODEV;
}
scom->fsi_dev = fsi_dev;
/* Create chardev for userspace access */
scom->dev.type = &fsi_cdev_type;