redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

i2c: i801: Fix kernel crash in is_dell_system_with_lis3lv02d() 

The commit

  19b07cb4a1 ("i2c: i801: Register optional lis3lv02d I2C device on Dell machines")

introduced a new check in order to enumerate some slave devices on Dell
machines. Though, it brings a regression on machines where DMI vendor is not set.

 BUG: kernel NULL pointer dereference, address: 0000000000000000
 #PF: supervisor read access in kernel mode
 #PF: error_code(0x0000) - not-present page
 PGD 0 P4D 0
 Oops: 0000 [#1] SMP PTI
 CPU: 8 PID: 1 Comm: swapper/0 Not tainted 5.2.0-rc4-next-20190613+ #317
 RIP: 0010:strcmp+0xc/0x20

To fix this crash, check if vendor field is present before accessing to it.

Fixes: 19b07cb4a1 ("i2c: i801: Register optional lis3lv02d I2C device on Dell machines")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
alistair/sunxi64-5.4-dsi
Andy Shevchenko 2019-06-13 19:45:27 +03:00 committed by Wolfram Sang
parent fdb7e884ad
commit aa5ae06515
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/i2c/busses/i2c-i801.c
View File

@ -1188,7 +1188,7 @@ static bool is_dell_system_with_lis3lv02d(void)
const char *vendor;
vendor = dmi_get_system_info(DMI_SYS_VENDOR);
if (strcmp(vendor, "Dell Inc.") != 0)
if (!vendor || strcmp(vendor, "Dell Inc."))
return false;
/*