KVM: return an error code in kvm_vm_ioctl_register_coalesced_mmio()
If kvm_io_bus_register_dev() fails then it returns success but it should
return an error code.
I also did a little cleanup like removing an impossible NULL test.
Cc: stable@vger.kernel.org
Fixes: 2b3c246a68
('KVM: Make coalesced mmio use a device per zone')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hifive-unleashed-5.1
parent
b73117c493
commit
aac5c4226e
|
@ -154,17 +154,13 @@ int kvm_vm_ioctl_register_coalesced_mmio(struct kvm *kvm,
|
||||||
list_add_tail(&dev->list, &kvm->coalesced_zones);
|
list_add_tail(&dev->list, &kvm->coalesced_zones);
|
||||||
mutex_unlock(&kvm->slots_lock);
|
mutex_unlock(&kvm->slots_lock);
|
||||||
|
|
||||||
return ret;
|
return 0;
|
||||||
|
|
||||||
out_free_dev:
|
out_free_dev:
|
||||||
mutex_unlock(&kvm->slots_lock);
|
mutex_unlock(&kvm->slots_lock);
|
||||||
|
|
||||||
kfree(dev);
|
kfree(dev);
|
||||||
|
|
||||||
if (dev == NULL)
|
return ret;
|
||||||
return -ENXIO;
|
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
int kvm_vm_ioctl_unregister_coalesced_mmio(struct kvm *kvm,
|
int kvm_vm_ioctl_unregister_coalesced_mmio(struct kvm *kvm,
|
||||||
|
|
Loading…
Reference in New Issue